Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Modified ocean/mesh/remap_topography to allow smoothing #863

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Modified ocean/mesh/remap_topography to allow smoothing #863

wants to merge 2 commits into from

Conversation

bmooremaley
Copy link

@bmooremaley bmooremaley commented Oct 7, 2024 •
edited
Loading

The ocean/mesh/remap_topography step has been modified to remap combined topography from a cubed sphere source grid to MPAS meshes, instead of a lat-lon source grid. The weights file generation has been switched to mbtempest so that smoothing can be defined in the target MPAS mesh SCRIP file. Smoothing parameters have been added to ocean/mesh/remap_topography.cfg. This new workflow also uses a pre-build source SCRIP file stored in the bathymetry database, in addition to the combined topography file.

Checklist

  • User's Guide has been updated
  • Developer's Guide has been updated
  • Documentation has been built locally and changes look as expected
  • Document (in a comment titled Testing in this PR) any testing that was used to verify the changes

@xylar xylar self-requested a review October 9, 2024 19:58
@xylar xylar self-assigned this Oct 9, 2024
@xylar xylar added enhancement New feature or request ocean labels Oct 9, 2024
xylar
xylar reviewed Oct 9, 2024
View reviewed changes
compass/ocean/mesh/remap_topography.py
Comment on lines +133 to +137
descriptor.to_scrip(
'target.scrip.nc',
expandDist=expandDist,
expandFactor=expandFactor,
)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Before this call, we want to make sure to set descriptor.format = 'NETCDF3_64BITDATA' (Check this, it's just my best guess on the names of the attribute and its value.)

@xylar
Copy link
Collaborator

xylar commented Oct 9, 2024

@bmooremaley, as we discussed, we'll need some way to support a different topography dataset for lower res regression testing. I pulled out the config options into their own config file:
#864
If we want to continue to support that 1/20 degree dataset, we would need a way to still use ESMF for that resolution. An alternative (if mbtempest if fast enough) is to use a lower resolution cubed-sphere dataset as we discussed and stick with the modified workflow you have here. I would lean slightly toward the latter so that the regression testing is using a more similar workflow to the high resolution runs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xylar xylar xylar left review comments

At least 1 approving review is required to merge this pull request.

Assignees

@xylar xylar

Labels
enhancement New feature or request ocean
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bmooremaley @xylar